-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Selection Copy + a11y features #110
Open
AlaricBaraou
wants to merge
31
commits into
protectwise:main
Choose a base branch
from
AlaricBaraou:master
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
2a950bc
screen readers / text selection / translation V0
AlaricBaraou 00e8feb
Merge remote-tracking branch 'upstream/master'
AlaricBaraou b410f0d
react to radius changes
AlaricBaraou 2fabe96
text selection color
AlaricBaraou aa2edfa
demo fix and selection thikness
AlaricBaraou 128d4c3
fix selection child transform
AlaricBaraou 09499ce
clear selection + selection material
AlaricBaraou 99e3047
Merge remote-tracking branch 'upstream/master'
AlaricBaraou cb24d4c
html correct position
AlaricBaraou b8f44d3
dom selection position
AlaricBaraou 413e158
overlaying html edge cases
AlaricBaraou 50d914c
translation keep formating
AlaricBaraou 45d839a
module separation v0
AlaricBaraou d58db14
use CSS matrix3d for aligning DOM overlays more accurately with persp…
lojjic 7d6bae2
cherry picked + SR outline
lojjic 42053ac
manage selection without deleting potential Text childs
AlaricBaraou d0623de
dynamic selection manager
AlaricBaraou c2d6250
bug fixs, cleaning
AlaricBaraou f15d0ce
fix selection color + comments
AlaricBaraou f812299
separate selectable and a11y in two make functions
AlaricBaraou 671d971
split textHighlighter
AlaricBaraou af344c5
TextHighlight as Group Subclass
AlaricBaraou 6325ae0
move props to makers
AlaricBaraou 04c4c8c
move textRectToCssMatrix to selectionutils
AlaricBaraou 63d3115
selection managed by TextHighligh, exposed by makeSelectable
AlaricBaraou 163d610
fix selectionMaterial
AlaricBaraou 696d6ab
fix a11y translation and text update
AlaricBaraou 3769051
make observeMutation optional
AlaricBaraou 16fdca6
fix merge conflict
AlaricBaraou ef15677
Merge branch 'master' into master
AlaricBaraou b580de6
Merge branch 'master' into master
AlaricBaraou File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the source of your Netlify build error, btw.