Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin client should not be allowed to login using the open project #62

Open
bdionne opened this issue Aug 31, 2016 · 3 comments
Open

Admin client should not be allowed to login using the open project #62

bdionne opened this issue Aug 31, 2016 · 3 comments

Comments

@bdionne
Copy link
Contributor

bdionne commented Aug 31, 2016

When opening a project remotely, if the user logins as an admin client by mistake they are not made aware of it until they open the project, at which point the user is already logged in and has to logout.

@rsgoncalves
Copy link
Member

It's probably best to disable the 'Open project from server' menu item to address this; if an admin can't open projects then the open project dialog shouldn't be an option in the first place.

@bdionne
Copy link
Contributor Author

bdionne commented Aug 31, 2016

hmm, no I meant the user uses the Open Project From Server menu item and it prompts for the login. This prompt occurs other times, pretty much whenever the session has timed out. In the case of the open, it allows the user to login as admin but then fails. In this case I think the login should not occur and the prompt to login should come back, perhaps with the url highlighted to inform the user they are inadvertently logging in as admin.

rsgoncalves pushed a commit that referenced this issue Sep 1, 2016
@bdionne
Copy link
Contributor Author

bdionne commented Sep 1, 2016

@rsgoncalves - just to clarify (the git commit message is useless :) - the new behavior seems to be:

If the user tries to Open Project From Server and then uses the 8081 port, we assume they mean to login ad admin and then make the open project dialog go away?

Wouldn't it be preferable to assume that they wanted to open a project and mistakenly used the wrong port (this was the actual scenario that produced the bug)?

@bdionne bdionne reopened this Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants