Save files using format-specific extensions. #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When saving an ontology, use extensions suitable to the format chosen by the user instead of systematically using ".owl".
matthewhorridge
added
the
Status: Needs Review
|
This looks great. Thanks so much for the contribution @gouttegd! |
This was referenced Jul 26, 2021
matthewhorridge
removed
the
Status: Needs Review
|
That is great. Thank you. Please not a small correction: #1017 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Protégé save a new ontology in a file with an extension suitable to the format chosen by the user, instead of systematically using a ".owl" extension regardless of the format.
It attempts to centralise the association between a format and its extensions in a new static
Extensionsclass, which can then be used both when saving a new file (to only allow extensions matching the intended save format) and when opening a file (to allow all extensions for all supported formats).Related to #969, #1012, and #1015.