Proposed upgrade of owlapi to 4.5.5 #798
Conversation
Nice to sync with ROBOT
|
travis fails... OK guess this is probably more complex |
|
I took a (very) quick look at the Travis log and noticed some messages about Guice. That was removed from OWLAPI somewhere between 4.2.8 and 4.5.5, and avoiding Guice is one reason that we want to update ROBOT (ontodev/robot#308). |
|
@cmungall, @jamesaoverton I've just had a look at this. It's to do with the assembly descriptor, which is looking for Guice libraries to copy into the distribution. Easy to fix. I'm able to build with 4.5.5 and all of the tests pass. We need to do some more testing and check that various plugins work okay... |
|
FYI I've just published the changes to get to 4.5.5 in a branch owlapi-4.5.5 |
|
ok needs a bit more work.... some class loading issues |
|
I'm not sure what's causing the class loading problems but I expect it's some problem with OSGi and the new OWL API custom DI mechanism. I've worked around this by doing manual injection from within Protege, which isn't necessarily a bad thing. The branch mentioned above builds and runs and seems to load and save ontologies okay. Some more eyes on this would be great. (just copying in @ignazio1977 so he's aware of what's going on) |
Nice to sync with ROBOT: ontodev/robot#355 (comment)