Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH-6 migrate to rdf4j #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

abrokenjester
Copy link

@abrokenjester abrokenjester commented Nov 17, 2018

This PR addresses issue #6

Changes:

  • migrate from sesame 2.7 to rdf4j 2.4
  • migrate from owl api 4.2 to 5.1

The owl api version bump was necessary because the older version used sesame internally.

This PR is not ready for merge as-is: in particular the class AnonymousResourceHandler needs scrutiny. This class used a lot of OWL API functionality that has significantly changed between version 4 and 5, and I couldn't immediately make sense of it. Feedback most welcome. My fork should be editable to the maintainers so if you wish to push fixes to my repo/branch, by all means do.

Signed-off-by: Jeen Broekstra <jeen.broekstra@gmail.com>
Signed-off-by: Jeen Broekstra <jeen.broekstra@gmail.com>
Signed-off-by: Jeen Broekstra <jeen.broekstra@gmail.com>
@matthewhorridge
Copy link
Contributor

Hi @jeenbroekstra thanks a lot for the contribution! Much appreciated.

We are kind of nervous about updating Protege to OWL API 5 right now as it is backwards incompatible with 4 and thus updating Protege with 5 has the potential to break a lot of plugins. I think we'll look at doing this for Protege 6 (we have a big Protege 5.5 release coming soon).

@abrokenjester
Copy link
Author

That makes sense. Unfortunately we can't switch to rdf4j without this upgrade. Only option I see is that we convince the owl API project to release a 4.3 release that updates to java 8 and rdf4j but doesn't change its own APIs. Not sure if that's realistic though.

@abrokenjester
Copy link
Author

@matthewhorridge you want to keep this PR open for future reference, or do you prefer to close it for now? Either way once you've started migration to OWLAPI 5 feel free to give me a nudge, happy to assist with sesame to rdf4j migration any way I can.

@matthewhorridge
Copy link
Contributor

@jeenbroekstra yes, I'll keep it open for future reference. Thanks so much for the kind offer of assistance - I really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants