Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

denote-keywords-{add|remove} a note under version control throws a vc.el error #185

Closed
willydeliege opened this issue Nov 3, 2023 · 3 comments
Closed

denote-keywords-{add|remove} a note under version control throws a vc.el error #185

willydeliege opened this issue Nov 3, 2023 · 3 comments

Comments

@willydeliege
Copy link

Hello,

When trying to add or remove keywords on a file under vc-control, the following error is thrown:
vc-rename-file: please save files before moving them
stopping the add/remove keywords - rename process
My configuration emacs 29.1 ubuntu package
Tested with denote 2.0 and the last development one
protesilaos added a commit that referenced this issue Nov 3, 2023
@protesilaos
Stop using vc-rename-file to rename files
0d7b819 
The reason is that it requires the buffer to be saved, but we do not
want that after modifying the front matter because we want to give the
user a chance to confirm what happened.

Thanks to Frédéric Willem for reporting the problem in issue 185 on
the GitHub mirror: <#185>.
@protesilaos
Copy link
Owner

Thank you @willydeliege! I removed the vc-rename-file operation for now. It requires the buffer to be saved. Maybe there is an alternative, but I am not seeing it right now.

@willydeliege
Copy link
Author

Thank you @willydeliege! I removed the vc-rename-file operation for now. It requires the buffer to be saved. Maybe there is an alternative, but I am not seeing it right now.
Thank you for you speednes @protesilaos.

@protesilaos
Copy link
Owner

You are welcome! And thank you for taking the time to report the bug. We can safely close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@protesilaos @willydeliege