Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

denote-silo-extras manual addition #216

Closed
l-o-l-h opened this issue Jan 1, 2024 · 2 comments
Closed

denote-silo-extras manual addition #216

l-o-l-h opened this issue Jan 1, 2024 · 2 comments

Comments

@l-o-l-h
Copy link

l-o-l-h commented Jan 1, 2024 •
edited

The manual Section 2.5.2 The denote-silo-extras.el introduces the three commands:

  1. denote-silo-extras-create-note
  2. denote-silo-extras-open-or-create
  3. denote-silo-extras-select-silo-then-command

The first two commands are set up to work interactively only with a prefix argument C-u, but this requirement is not made known by the manual. If a prefix argument is not provided, then the command runs the wrapped command (e.g., denote or denote-open-or-create) using the default denote directory or a previously used silo directory. The manual could be improved by including the prefix requirement to choose a silo directory.
@protesilaos
Copy link
Owner

Hello @l-o-l-h! The commands are wrong. They should not require a C-u for that. I will update them now.

protesilaos added a commit that referenced this issue Jan 25, 2024
@protesilaos
Make silo commands not require superfluous prefix argument
fa5548f 
This was a mistake. The intent was to run those commands without a
prefix argument.

Thanks to l-o-l-h for mentioning this in issue 216:
<#216>.
@l-o-l-h
Copy link
Author

l-o-l-h commented Jan 26, 2024

@protesilaos
Thank you. The new code resolves this issue beautifully. This issue can be closed as resolved.

@l-o-l-h l-o-l-h closed this as completed Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@protesilaos @l-o-l-h