New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposing to remove Denote extension "modules" from the source #264
Comments
Hello @nobiot!
You mean to remove it completely? I know that the project.el parts are probably not useful anymore because we do not use the project file prompt (it did not support all the features we need). The rest I am not sure.
I think the coming days are suitable for this, because I will try to publish a new version within the coming weeks. But I do not mind if we do it later and then bundle it with the new series of changes, such as those outlined by @jeanphilippegg here: #257. |
Hi @protesilaos Prot :)
Yes, that's my proposal, but I have no objection if you decide to keep it in a separate .el file. Your call.
The project module was originally intended for those who do not use
I don't think I will be able to support these modules much; this is also a reason for my proposal. If they are not used, why do we keep them? It would be a maintenance burden for you and me. This was the thought I had when I proposed the removal. |
Thank you @nobiot! I will take a closer look at them and act accordingly. I have the impression they are still useful, if not in full then at least in part. I am, in particular, interested in the project.el integration because the file prompt we have now does not show relative file paths. |
This was done upon the request of Noboru Ota (nobiot), who is the author of this code. The discussion is part of issue 264: <#264>.
Okay, I removed them. The project-like file prompt can be done on its own. I updated it. Thank you! |
@protesilaos Thank you! |
Regarding this comment in the source
I agree with this comment. I wrote this part while ago when Denote development was still in an early stage.I propose that the part be entirely removed from the source.
I suspect I am the only user for the modules, and I have factored out what I need from them, so there is no impact for me.
There was not much discussion on it in the SourceHut mailing list when it was in use. I think it is a technical debt now and I would not like it become your maintenance burden.
I will leave it to you for the timing of the removal.
The text was updated successfully, but these errors were encountered: