Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiword keyword and fontification issue #9

Closed
svnsbck opened this issue Jun 11, 2022 · 6 comments
Closed

Multiword keyword and fontification issue #9

svnsbck opened this issue Jun 11, 2022 · 6 comments

Comments

@svnsbck
Copy link

svnsbck commented Jun 11, 2022

Hi Prot!
The latest change with the keywords is nice and certainly adds clarity, but somehow the fontification in Dired doesn't correctly work, or at the least it doesn't on my end:

Screenshot from 2022-06-11 16-43-35

Entries with multiple keywords work as expected.

Of course I might have messed up something myself. Always a possibility :-)

@protesilaos
Copy link
Owner

Hello @svnsbck! The fault is not yours. Just fixed it in commit d83c166. Please give it a try.

protesilaos added a commit that referenced this issue Jun 11, 2022
Regression was caused by commit 7cba33e.  Thanks to svnsbck for
reporting the problem in issue 9 over at the GitHub mirror:
<#9>.
@svnsbck
Copy link
Author

svnsbck commented Jun 11, 2022

Great! Just gave it a try and it works now.

Screenshot from 2022-06-11 18-09-39

One idea that came to mind is, if the separator (ie. the underscore) between the keywords could have the same color, the light-grey, as the other separators. Surely it is only a minor difference but I think it would visually clarify that its two different keywords and not just one very long one which contains underscores.

I don't know if that's even possible though.

protesilaos added a commit that referenced this issue Jun 11, 2022
Thanks to svnsbck for suggesting the idea in issue 9 over at the GitHub
mirror: <#9>.
@protesilaos
Copy link
Owner

One idea that came to mind is, if the separator (ie. the underscore)
between the keywords could have the same color, the light-grey, as the
other separators. Surely it is only a minor difference but I think it
would visually clarify that its two different keywords and not just
one very long one which contains underscores.

Good idea! Done in commit 142b628. I might still tweak it a bit further.

@protesilaos
Copy link
Owner

Also adjusted the grey colour of the field delimiters. We now have these:

Screenshot from 2022-06-11 18-46-05

Screenshot from 2022-06-11 18-45-14

@svnsbck
Copy link
Author

svnsbck commented Jun 11, 2022 via email

@protesilaos
Copy link
Owner

Thanks! Closing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants