Fix to signature losing "="s when file is renamed. #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Four file renaming commands may lose spaces (denoted by the "=" in existing filenames) when the user renames the file: 1. denote-rename-file 2. denote-dired-rename-files 3. denote-dired-rename-marked-files-with-keywords 4. denote-rename-file-using-front-matter This is caused by the function `denote-sluggify-signature`, which calls (indirectly) `denote--slug-no-punct`, which removes, among many other characters, all "="s, which represent spaces. These spaces are thus lost even if the user does not change the signature. To remedy this situation, all "="s are turned into spaces before being sent to `denote--slug-no-punct`, as spaces are not removed by this function. The function `denote--slug-put-equals` turns these spaces into "="s at the end of the file-renaming operation.
Merged
|
Merged. Thank you! |
protesilaos
added a commit
that referenced
this pull request
Jan 1, 2024
The change is within the ~15 line limit and so Wesley Harvey does not need to assign copyright to the Free Software Foundation. That commit was done in pull request 207 on the GitHub mirror: <#207>.
|
Oh, and a Happy New Year! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Four file renaming commands may lose spaces (denoted by the "=" in existing filenames) when the user renames the file:
This is caused by the function
denote-sluggify-signature, which calls (indirectly)denote--slug-no-punct, which removes, among many other characters, all "="s, which represent spaces. These spaces are thus lost even if the user does not change the signature.To remedy this situation, all "="s are turned into spaces before being sent to
denote--slug-no-punct, as spaces are not removed by this function. The functiondenote--slug-put-equalsturns these spaces into "="s at the end of the file-renaming operation.