Reintroduce function denote-project-find from commit ac0c361 #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanphilippegg
force-pushed
the
denote-project-find
branch
from
37fa944
to
e4cfd7b
Compare
|
Thank you @jeanphilippegg. Note that your patch covers more than the reintroduction of |
protesilaos
added a commit
that referenced
this pull request
Mar 13, 2024
We had removed this in commit ac0c361, thinking it was not necessary, though Alan Schmitt reported a case where we actually needed this functionality. This was reported in issue 283: <#283>. Thanks to Jean-Philippe Gagné Guay for identifying the regression and for taking the initiative to bring back the feature in pull request 286: <#286>. We cannot merge that one because it includes other in-development snippets.
|
I just posted this in the issue tracker about the regression: #283 (comment). Closing now. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backlinks buffer needs it.
This fixes issue #283.