Cleanup #94
Merged
Cleanup #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not check if the file is inside denote-directory.
jeanphilippegg
force-pushed
the
cleanup
branch
from
376786c
to
c81c6b7
Compare
- Move the check in denote-rename-file and denote-dired-rename-marked-files
jeanphilippegg
force-pushed
the
cleanup
branch
from
376786c
to
d4d67a6
Compare
|
Merged. Thank you! |
|
I added an obsoletion for the |
|
Ok, good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup to remove checks from various functions as discussed in #91 and other minor simplifications.
I also added an
stodenote-backlink-modeanddenote-backlink-mode-mapand made the latter obsolete and removed the todo item. I don't know if we can makedenote-backlink-modeobsolete. Now, onlydenote-link-backlink-buttonanddenote-link--backlink-find-filehave abacklinkwithout ans. It is good with me. Maybe you would prefer to have singularbacklinkeverywhere?