Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doom-modeline-urgent cropped icon #42

Closed
fargiolas opened this issue Apr 20, 2024 · 1 comment
Closed

doom-modeline-urgent cropped icon #42

fargiolas opened this issue Apr 20, 2024 · 1 comment

Comments

@fargiolas
Copy link

fargiolas commented Apr 20, 2024

Seeing this with ef-dream but that's probably in common with all the ef-themes (and maybe modus?).

The icon next to the flymake error count in doom-modeline is slanted and the right part is slightly cropped.
Probably depends on the combination of fonts and icons? screenshot is from master with Menlo and nerd icons.

Same does not happen inheriting from bold instead of bold-italic.

I think the real problem is doom applying the same face to text and icon and italic icon not making much sense, but maybe we could live without the italic at all? I guess icon and color already convey the urgency?

ef-dream

Thanks! (and thanks for the all the beautiful themes, especially the new ef-reverie and ef-dream, love them! thanks for everything you do!)

protesilaos added a commit that referenced this issue Apr 27, 2024
Thanks to Filippo Argiolas for reporting this bug issue 42:
<#42>.
@protesilaos
Copy link
Owner

Thank you @fargiolas!

I just pushed an update that removes the bold-italic.

protesilaos added a commit to protesilaos/modus-themes that referenced this issue Apr 27, 2024
Thanks to Filippo Argiolas for reporting this bug in issue 42 at the
ef-themes repo: <protesilaos/ef-themes#42>.
protesilaos added a commit to protesilaos/standard-themes that referenced this issue Apr 27, 2024
Thanks to Filippo Argiolas for reporting this bug in issue 42 at the
ef-themes repo: <protesilaos/ef-themes#42>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants