should probably unify the colors of imenu-list-entry-subalist-face and menu-list-entry-face

[ltmsyvag]

Modus lover here!

The imenu-list face settings in modus-themes.el, namely:

modus-themes/modus-themes.el

Lines 2647 to 2654 in 5a777c3

	`(imenu-list-entry-face-0 ((,c :foreground ,fg-heading-1)))
	`(imenu-list-entry-face-1 ((,c :foreground ,fg-heading-2)))
	`(imenu-list-entry-face-2 ((,c :foreground ,fg-heading-3)))
	`(imenu-list-entry-face-3 ((,c :foreground ,fg-heading-4)))
	`(imenu-list-entry-subalist-face-0 ((,c :inherit bold :foreground ,fg-heading-5 :underline t)))
	`(imenu-list-entry-subalist-face-1 ((,c :inherit bold :foreground ,fg-heading-6 :underline t)))
	`(imenu-list-entry-subalist-face-2 ((,c :inherit bold :foreground ,fg-heading-7 :underline t)))
	`(imenu-list-entry-subalist-face-3 ((,c :inherit bold :foreground ,fg-heading-8 :underline t)))

set 8 different colors for 8 different imenu-list faces, but this is causing visual confusion. Because in fact, an imenu-list entry imenu-list-entry-subalist-face-<num> is at the same level as imenu-list-entry-face-<num> (they have the same <num> !), the only difference is that the former contains sub-entires.

The modus-vivendi colorization of imenu-list now looks like:

which is confusing, because "Earth" is at the same level as Venus, but it has a different color. What's NOT confusing would look like below:

Without modus-themes, the above is also the default behavior of imenu-list, which I produce below with a vanilla-ish emacs:

[protesilaos]

Thank you @ltmsyvag! You are right. I don't remember why it was with eight colours before. Just made the change.