Skip to content

Commit

Permalink
fix(types): reserved field in IType can contain reserved names (#2001)
Browse files Browse the repository at this point in the history
* Fix the type of reserved field in IType

* Fix the type issue in src file
  • Loading branch information
mkruskal-google committed Jun 5, 2024
1 parent 11393ea commit d1d2c0c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1698,7 +1698,7 @@ export interface IType extends INamespace {
extensions?: number[][];

/** Reserved ranges */
reserved?: number[][];
reserved?: (number[]|string)[];

/** Whether a legacy group or not */
group?: boolean;
Expand Down
2 changes: 1 addition & 1 deletion src/type.js
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ function clearCache(type) {
* @property {Object.<string,IOneOf>} [oneofs] Oneof descriptors
* @property {Object.<string,IField>} fields Field descriptors
* @property {number[][]} [extensions] Extension ranges
* @property {number[][]} [reserved] Reserved ranges
* @property {Array.<number[]|string>} [reserved] Reserved ranges
* @property {boolean} [group=false] Whether a legacy group or not
*/

Expand Down

0 comments on commit d1d2c0c

Please sign in to comment.