We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi! 👋
I've found out the "valuesOptions" option in Enum class is missing when parsed from the JSON.
Reproduction:
The following code change should fix it:
diff --git a/node_modules/protobufjs/src/enum.js b/node_modules/protobufjs/src/enum.js index 1c01620..730b8e4 100644 --- a/node_modules/protobufjs/src/enum.js +++ b/node_modules/protobufjs/src/enum.js @@ -87,7 +87,7 @@ function Enum(name, values, options, comment, comments, valuesOptions) { * @throws {TypeError} If arguments are invalid */ Enum.fromJSON = function fromJSON(name, json) { - var enm = new Enum(name, json.values, json.options, json.comment, json.comments); + var enm = new Enum(name, json.values, json.options, json.comment, json.comments, json.valuesOptions); enm.reserved = json.reserved; return enm; };
This issue body was partially generated by patch-package.
The text was updated successfully, but these errors were encountered:
Fix missing valuesOptions in fromJSON parser function
0994a25
I've found out that the "valuesOptions" option in the Enum class is missing when parsed from the JSON. This PR should fix the issue: protobufjs#1961
No branches or pull requests
Hi! 👋
I've found out the "valuesOptions" option in Enum class is missing when parsed from the JSON.
Reproduction:
The following code change should fix it:
This issue body was partially generated by patch-package.
The text was updated successfully, but these errors were encountered: