Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About imports implemention #2

Closed
tiantian20007 opened this issue Mar 15, 2013 · 4 comments
Closed

About imports implemention #2

tiantian20007 opened this issue Mar 15, 2013 · 4 comments

Comments

@tiantian20007
Copy link

As package "some" define in some.proto import package "common" define in common.proto
May it be used like this:
var commonBuilder = ProtoBuf.protoFromFile("common.proto");
var someBuilder = ProtoBuf.protoFromFile("some.proto", commonBuilder);
var Some = someBuilder.build("some");
var some = new some() ...

@dcodeIO
Copy link
Member

dcodeIO commented Mar 15, 2013

I like the idea, I will look into this!

@ghost ghost assigned dcodeIO Mar 15, 2013
@dcodeIO
Copy link
Member

dcodeIO commented Mar 15, 2013

@dcodeIO dcodeIO closed this as completed Mar 15, 2013
@tiantian20007
Copy link
Author

It works. Great job! Thx a lot! However I had to ignore "import" declared in my .proto files manually for it is consider to be Illegal ^^

@dcodeIO
Copy link
Member

dcodeIO commented Mar 21, 2013

Imports are fully supported as of 0.12.0: see/Imports

nicolasnoble pushed a commit that referenced this issue May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants