Enable overriding google.protobuf namespace in fromDescriptor #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusLongmuir
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1072 <- Full explanation of the feature request in this issue.
TL;DR for the above issue - To enable usage of custom options in descriptors being decoded with
fromDescriptoryou need to be able to override thegoogle.protobufnamespace used to decode aFileDescriptorSetwith one that has the extensions of theMessageOptionsdefined. You also need to have the resulting descriptor use camelCased field names as that's what thefromDescriptorcode uses (they come from the JSON field names indescriptor.json).I understand this is an experimental feature at the moment and there isn't much test coverage for this as far as I can tell, but I'm happy to add tests for this if someone can describe how they should work.