New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't imply --wrap es6 from --es6 in pbjs #1430

Merged

nicolasnoble merged 1 commit into protobufjs:master from webmaster128:allow-commonjs-es6

Jun 26, 2020

Contributor

webmaster128 commented Jun 18, 2020

The documented and epected behaviour is that --wrap es6 implies ---es6 but not the other way around.

Closes #1308


          Don't imply --wrap es6 from --es6

6698d59

webmaster128 mentioned this pull request

--es6 in combination with --wrap commonjs not possible #1308

Closed

webmaster128 changed the title ~~Don't imply --wrap es6 from --es6~~ fix: Don't imply --wrap es6 from --es6 in pbjs

murgatroid99 approved these changes

View reviewed changes

nicolasnoble merged commit b6abd93 into protobufjs:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment