Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix RPCImplCallback type declaration - make Error optional #766

Closed
wants to merge 2 commits into from
Closed

fix RPCImplCallback type declaration - make Error optional #766

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1d7d0a
fix RPCImplCallback type declaration - make Error optional
rossenassenov Apr 19, 2017
caf95ca
fix RPCImplCallback declaration - make error an optional parameter
rossenassenov Apr 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/rpc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ var rpc = exports;
* Node-style callback as used by {@link RPCImpl}.
* @typedef RPCImplCallback
* @type {function}
* @param {?Error} error Error, if any, otherwise `null`
* @param {?Error} [error] Error, if any, otherwise `null`
* @param {?Uint8Array} [response] Response data or `null` to signal end of stream, if there hasn't been an error
* @returns {undefined}
*/
Expand Down