Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support protobuf v21.0 rc1 #125

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

Katee
Copy link
Contributor

@Katee Katee commented Aug 1, 2022

I've also tested this using v21.4 (the latest release) but did not test any releases between those two.

I tested using:

$ npm install
$ bazel build @com_google_protobuf//:protoc
$ PROTOC="$(realpath bazel-bin/external/com_google_protobuf/protoc)" PROTOC_INC="$(realpath bazel-protobuf-javascript/external/com_google_protobuf/src/)" npm test

It may also make sense to update the version of protobuf-javascript here to match the version of protobuf.

@dibenede
Copy link
Contributor

dibenede commented Aug 1, 2022

I've also tested this using v21.4 (the latest release) but did not test any releases between those two.

What's the motivation for using v21.0 rc1 specifically?

It may also make sense to update the version of protobuf-javascript here to match the version of protobuf.

The current plan is to just continue the versioning we started with.

@Katee
Copy link
Contributor Author

Katee commented Aug 1, 2022

What's the motivation for using v21.0 rc1 specifically?

v21.0 rc1 is the first release of protobuf after the javascript folder was removed: https://github.com/protocolbuffers/protobuf/releases/tag/v21.0-rc1 v21.0 could also make sense since that's the first non-candidate version. v21.4 could also makes sense since it is the most recent version.

The current plan is to just continue the versioning we started with.

Sure, you certainly don't need to match the protobuf version.

@dibenede dibenede merged commit a428c58 into protocolbuffers:main Aug 1, 2022
@Katee Katee deleted the support-protobuf-v21.0-rc1 branch August 1, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants