Re-enable advanced optimizations and add binary/ tests for CommonJS #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukesandberg
approved these changes
Oct 14, 2022
|
|
||
| function enableSimpleOptimizations(cb) { | ||
| compilationLevel = 'SIMPLE'; | ||
| cb(); |
| @@ -49,16 +49,19 @@ goog.provide('jspb.arith.UInt64'); | |||
| * @param {number} lo The low 32 bits. | |||
| * @param {number} hi The high 32 bits. | |||
| * @constructor | |||
| * @export | |||
There was a problem hiding this comment.
this is an example of something that is only being exported for tests
can you open an issue to look into removing export from APIs like this to improve size and just note that this will require a test refactoring.
This was referenced Oct 14, 2022
gbl08ma
added a commit
to tnyim/jungletv
that referenced
this pull request
Jul 29, 2023
This is so we get the bundle size optimizations the official package still hasn't cut in a release, after almost one year: protocolbuffers/protobuf-javascript#146 (and yes I was too lazy to get it to compile so I wouldn't depend on a sketchy fork) (the sketchy fork is used in TRON cryptocurrency stuff too, we should be fine, cough cough)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.