Check the message to be encoded is the wrong type. (#4885)

protocolbuffers · Jul 12, 2018 · 40f9ef2 · 40f9ef2
1 parent 0a59054
commit 40f9ef2
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/ruby/ext/google/protobuf_c/encode_decode.c b/ruby/ext/google/protobuf_c/encode_decode.c
@@ -1108,6 +1108,13 @@ static void putmsg(VALUE msg_rb, const Descriptor* desc,
 
   TypedData_Get_Struct(msg_rb, MessageHeader, &Message_type, msg);
 
+  if (desc != msg->descriptor) {
+    rb_raise(cTypeError,
+             "The type of given msg is '%s', expect '%s'.",
+             upb_msgdef_fullname(msg->descriptor->msgdef),
+             upb_msgdef_fullname(desc->msgdef));
+  }
+
   for (upb_msg_field_begin(&i, desc->msgdef);
        !upb_msg_field_done(&i);
        upb_msg_field_next(&i)) {

diff --git a/ruby/tests/encode_decode_test.rb b/ruby/tests/encode_decode_test.rb
@@ -84,4 +84,14 @@ def test_encode_json
 
     assert_match 'optional_int32', json
   end
+
+  def test_encode_wrong_msg
+    e = assert_raise Google::Protobuf::TypeError do
+      m = A::B::C::TestMessage.new(
+          :optional_int32 => 1,
+      )
+      Google::Protobuf::Any.encode(m)
+    end
+  end
+
 end