Skip to content

Commit

Permalink
Remove errorprone dependency from kotlin protos.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 512960332
  • Loading branch information
deannagarcia authored and Copybara-Service committed Feb 28, 2023
1 parent 2dc5338 commit 7b6e828
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 18 deletions.
1 change: 0 additions & 1 deletion java/kotlin/BUILD.bazel
Expand Up @@ -25,7 +25,6 @@ kt_jvm_library(
deps = [
":only_for_use_in_proto_generated_code_its_generator_and_tests",
"//java/lite",
"@maven//:com_google_errorprone_error_prone_annotations",
],
)

Expand Down
5 changes: 0 additions & 5 deletions java/kotlin/pom.xml
Expand Up @@ -34,11 +34,6 @@
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_annotations</artifactId>
<version>2.5.1</version>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
Expand Down
6 changes: 0 additions & 6 deletions src/google/protobuf/compiler/java/message.cc
Expand Up @@ -1305,9 +1305,6 @@ void ImmutableMessageGenerator::GenerateKotlinMembers(
"camelcase_name",
name_resolver_->GetKotlinFactoryName(descriptor_));

if (!context_->options().opensource_runtime) {
printer->Print("@com.google.errorprone.annotations.CheckReturnValue\n");
}

printer->Print(
"public inline fun $camelcase_name$(block: $message_kt$.Dsl.() -> "
Expand Down Expand Up @@ -1340,9 +1337,6 @@ void ImmutableMessageGenerator::GenerateTopLevelKotlinMembers(
io::Printer* printer) const {
printer->Print("@kotlin.jvm.JvmSynthetic\n");

if (context_->options().opensource_runtime) {
printer->Print("@com.google.errorprone.annotations.CheckReturnValue\n");
}

printer->Print(
"public inline fun $message$.copy(block: $message_kt$.Dsl.() -> "
Expand Down
6 changes: 0 additions & 6 deletions src/google/protobuf/compiler/java/message_lite.cc
Expand Up @@ -816,9 +816,6 @@ void ImmutableMessageLiteGenerator::GenerateKotlinMembers(
"camelcase_name",
name_resolver_->GetKotlinFactoryName(descriptor_));

if (!context_->options().opensource_runtime) {
printer->Print("@com.google.errorprone.annotations.CheckReturnValue\n");
}
printer->Print(
"public inline fun $camelcase_name$(block: $message_kt$.Dsl.() -> "
"kotlin.Unit): $message$ =\n"
Expand Down Expand Up @@ -846,9 +843,6 @@ void ImmutableMessageLiteGenerator::GenerateKotlinMembers(

void ImmutableMessageLiteGenerator::GenerateTopLevelKotlinMembers(
io::Printer* printer) const {
if (!context_->options().opensource_runtime) {
printer->Print("@com.google.errorprone.annotations.CheckReturnValue\n");
}
printer->Print(
"public inline fun $message$.copy(block: $message_kt$.Dsl.() -> "
"kotlin.Unit): $message$ =\n"
Expand Down

0 comments on commit 7b6e828

Please sign in to comment.