Skip to content

Commit

Permalink
Downgrade our sanitized builds to ubuntu-20.
Browse files Browse the repository at this point in the history
The latest github runner image of ubuntu-22 includes a kernel update that breaks the sanitizers we use in our docker images.  Long-term, we'll likely need to upgrade the images to new sanitizers and clang.

PiperOrigin-RevId: 616319042
  • Loading branch information
mkruskal-google authored and zhangskz committed Jul 8, 2024
1 parent aa32865 commit 892a2ce
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/test_cpp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,9 @@ jobs:
config:
- { name: Optimized, flags: --config=opt }
- { name: Debug, flags: --config=dbg }
- { name: ASAN, flags: --config=asan, runner: ubuntu-22-large }
- { name: MSAN, flags: --config=docker-msan, runner: ubuntu-22-large }
# TODO Disable until TSAN bug is resolved
# - { name: TSAN, flags: --config=tsan }
- { name: ASAN, flags: --config=asan, runner: ubuntu-20-large }
- { name: MSAN, flags: --config=docker-msan, runner: ubuntu-20-large }
- { name: TSAN, flags: --config=tsan, runner: ubuntu-20-large }
- { name: UBSAN, flags: --config=ubsan }
- { name: No-RTTI, flags: --cxxopt=-fno-rtti }
include:
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/test_upb.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,13 @@ jobs:
config:
- { name: "Fastbuild" }
- { name: "Optimized", flags: "-c opt" }
- { name: "FastTable", flags: "--//upb:fasttable_enabled=true" }
- { name: "ASAN", flags: "--config=asan -c dbg", exclude-targets: "-//benchmarks:benchmark -//python/..." }
- { name: "ASAN", flags: "--config=asan -c dbg", exclude-targets: "-//benchmarks:benchmark -//python/...", runner: ubuntu-20-large }
- { name: "UBSAN", flags: "--config=ubsan -c dbg", exclude-targets: "-//benchmarks:benchmark -//python/... -//lua/..." }
- { name: "32-bit", flags: "--copt=-m32 --linkopt=-m32", exclude-targets: "-//benchmarks:benchmark -//python/..." }
# TODO: b/297027295 - Add 32-bit ASAN test

name: ${{ matrix.config.name }}
runs-on: ubuntu-latest
runs-on: ${{ matrix.config.runner || 'ubuntu-latest' }}

steps:
- name: Checkout pending changes
Expand Down

0 comments on commit 892a2ce

Please sign in to comment.