Skip to content

Commit

Permalink
Include .inc files directly instead of through a filegroup (#14575)
Browse files Browse the repository at this point in the history
gRPC auto-generates CMake and other build configs from the Bazel build graph,
but the logic for doing this does not know how to handle filegroups. This
change works around that problem by making the `:port` target refer directly to
the `.inc` files instead of going through a filegroup. This solution is not
ideal but I think it's probably the best way to unblock progress for now.

PiperOrigin-RevId: 578333954
  • Loading branch information
acozzette committed Nov 1, 2023
1 parent 0a5d6d4 commit 8defef5
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion upb/port/BUILD
Expand Up @@ -14,7 +14,15 @@ cc_library(
"vsnprintf_compat.h",
],
copts = UPB_DEFAULT_COPTS,
textual_hdrs = [":inc"],
textual_hdrs = [
# We must list the headers explicitly here instead of relying on the
# :inc filegroup below. gRPC auto-generates various build configs from
# the Bazel graph, and this logic does not know how to handle
# filegroups. We might be able to replace these headers with just
# ":inc" after gRPC starts using upb's CMake build.
"def.inc",
"undef.inc",
],
visibility = ["//visibility:public"],
)

Expand Down

0 comments on commit 8defef5

Please sign in to comment.