-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protobuf release artifacts do not include language-specific features protos #16211
Comments
This is a bug assuming you got these results by installing protoc and the C++ runtime. We should be shipping features protos with the corresponding runtime, so you should see cpp_features.proto here. Java features are separately put in the wrong place (see #16155) |
I just downloaded the relevant artifact for my machine from the "Artifacts" section, at the bottom of the GitHub release. So if I download the Java runtime, I'm expected to manually unpack the proto source from that JAR and put that directory in my include path? Why not include it with the other standard include files? If that location in the runtime JAR is easily consumed from a code gen task in Maven or Gradle, what about if I'm using the same proto and doing code gen for many languages, and need access to all of the features from a single file? Then I need the Java features source file, even for generating C++, since the source file imports it. |
yea that's a good point, maybe we should include all of these from our GH artifacts |
The major problem I see is that we're also shipping these protos and their gencode with our runtime releases. So there's a concern about version skew if we release them to two different places |
How are they different from |
…r Java and C++ Fixes #16211 PiperOrigin-RevId: 618933090
…r Java and C++ Fixes #16211 PiperOrigin-RevId: 618933090
…r Java and C++ Fixes #16211 PiperOrigin-RevId: 618933090
…r Java and C++ Fixes #16211 PiperOrigin-RevId: 618954029
…r Java and C++ Fixes protocolbuffers#16211 PiperOrigin-RevId: 618954029
The release artifacts for v26.0 do not include the protos for controlling language specific features. The repo includes
google/protobuf/cpp_features.proto
andgoogle/protobuf/java_features.proto
(though the latter is a bit buried, actually injava/core/src/main/java/com/google/protobuf
). And the Editions docs reference these two files. But the actual distribution does not include them:Is this a mistake? If not, how are users intended to obtain these files in order to import them from their own proto sources?
The text was updated successfully, but these errors were encountered: