Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# ByteString's hashcode is suboptimal #2511

Closed
jtattermusch opened this issue Dec 16, 2016 · 0 comments
Closed

C# ByteString's hashcode is suboptimal #2511

jtattermusch opened this issue Dec 16, 2016 · 0 comments
Assignees
@jskeet
Labels
c#

Comments

@jtattermusch
Copy link
Contributor

jtattermusch commented Dec 16, 2016 •
edited
Loading

https://github.com/google/protobuf/blob/a95e38ce8dec20d327692f4f5c2b0d37d6776696/csharp/src/Google.Protobuf/ByteString.cs#L306
@jtattermusch jtattermusch changed the title C# ByteStrings C# ByteString's hashcode is suboptimal Dec 16, 2016
jskeet added a commit to jskeet/protobuf that referenced this issue Dec 16, 2016
@jskeet
Give C# ByteString a sensible GetHashCode implementation.
56977cf 
Fixes protocolbuffers#2511.
@jskeet jskeet mentioned this issue Dec 16, 2016
Merged
jskeet added a commit that referenced this issue Dec 16, 2016
@jskeet
Give C# ByteString a sensible GetHashCode implementation.
b18bc9b 
Fixes #2511.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jskeet jskeet

Labels
c#
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jskeet @jtattermusch