Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup CI on for Visual Studio build #403

Closed
jtattermusch opened this issue May 19, 2015 · 1 comment
Closed

Setup CI on for Visual Studio build #403

jtattermusch opened this issue May 19, 2015 · 1 comment

Comments

@jtattermusch
Copy link
Contributor

We should test if Windows build is fine on each pull request, or at least for HEAD of master. Like this we are finding ourselves fixing stuff that should be discovered before merging (#395 #400 and I am sure there are others).

For gRPC we have a private Jenkins instance on Windows that verifies VS build.
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Jan 20, 2016

We are using appveyor to test C++ and C# on windows now.

@xfxyjwf xfxyjwf closed this as completed Jan 20, 2016
taoso pushed a commit to taoso/protobuf that referenced this issue Aug 1, 2018
@dsnet
proto: ignore unknown fields in map entries (protocolbuffers#561)
b028a76 
A proto map entry is conceptually a message with two fields.
In the same way that unknown fields don't cause a parsing error,
map parsing should ignore unknown fields and tags.
Similarly, it treats a missing field as the zero value.

Fixes protocolbuffers#403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xfxyjwf @jtattermusch