Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Java pom Export-Package should be 2.6.1, not 2.6.0 #47

Closed
protobufel opened this issue Oct 10, 2014 · 3 comments
Closed

In Java pom Export-Package should be 2.6.1, not 2.6.0 #47

protobufel opened this issue Oct 10, 2014 · 3 comments

Comments

@protobufel
Copy link

No description provided.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Oct 10, 2014

It's 2.6.1rc1 in the 2.6.1 branch:
https://github.com/google/protobuf/blob/2.6.1/java/pom.xml

@xfxyjwf xfxyjwf closed this as completed Oct 10, 2014
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Oct 10, 2014

FYI. I just merged all changes in 2.6.1 into the master branch.

@protobufel
Copy link
Author

I've looked at the pom in the distribution, there it's 2.6.0 :) Not a
problem if you're rebuilding from the branch, though.
On Oct 10, 2014 3:13 PM, "Feng Xiao" notifications@github.com wrote:

It's 2.6.1rc1 in the 2.6.1 branch:
https://github.com/google/protobuf/blob/2.6.1/java/pom.xml

—
Reply to this email directly or view it on GitHub
#47 (comment).

TeBoring pushed a commit to TeBoring/protobuf that referenced this issue Jan 19, 2019
@haberman
Merge pull request protocolbuffers#47 from haberman/compact
ff6fe32 
Optimized upb_inttable_compact(): it shrinks inttables more now.
@arnow117 arnow117 mentioned this issue Apr 1, 2019
Closed
copybara-service bot pushed a commit that referenced this issue Jan 31, 2024
@bshaffer
feat: more readable phpdoc escaping (#11208)
db9e05f 
The PHPDoc escaping in PHP is aggressive in that it escapes some character sequences that don't need to be escaped (`/*`), and it uses HTML entities to escape others (`*/` and `@`) instead of the recommended PHPDoc escape sequences.

For Example, in [`Google\Api\RoutingParameter`](https://github.com/googleapis/common-protos-php/blob/main/src/Api/RoutingParameter.php#L42):

```
 * path_template: "projects/*/{table_location=instances/*}/tables/*"
```

Should be escaped as:

```
 * path_template: "projects/{@*}{table_location=instances/*}/tables/*"
```

according to [the PHPDoc guide](https://manual.phpdoc.org/HTMLframesConverter/default/phpDocumentor/tutorial_phpDocumentor.howto.pkg.html#basics.desc):

 - For `@`: "if you need an actual "@" in your DocBlock's description parts, you should be careful to either ensure it is not the first character on a line, or else escape it ("\\@") to avoid it being interpreted as a PhpDocumentor tag marker."

 - For `*/`: " If you need to use the closing comment "\*/" in a DocBlock, use the special escape sequence "{@*}."

Closes #11208

COPYBARA_INTEGRATE_REVIEW=#11208 from bshaffer:more-readable-phpdoc-escaping a75f974
FUTURE_COPYBARA_INTEGRATE_REVIEW=#11208 from bshaffer:more-readable-phpdoc-escaping a75f974
PiperOrigin-RevId: 602870442
copybara-service bot pushed a commit that referenced this issue Jan 31, 2024
@bshaffer
feat: more readable phpdoc escaping (#11208)
f929439 
The PHPDoc escaping in PHP is aggressive in that it escapes some character sequences that don't need to be escaped (`/*`), and it uses HTML entities to escape others (`*/` and `@`) instead of the recommended PHPDoc escape sequences.

For Example, in [`Google\Api\RoutingParameter`](https://github.com/googleapis/common-protos-php/blob/main/src/Api/RoutingParameter.php#L42):

```
 * path_template: "projects/*/{table_location=instances/*}/tables/*"
```

Should be escaped as:

```
 * path_template: "projects/{@*}{table_location=instances/*}/tables/*"
```

according to [the PHPDoc guide](https://manual.phpdoc.org/HTMLframesConverter/default/phpDocumentor/tutorial_phpDocumentor.howto.pkg.html#basics.desc):

 - For `@`: "if you need an actual "@" in your DocBlock's description parts, you should be careful to either ensure it is not the first character on a line, or else escape it ("\\@") to avoid it being interpreted as a PhpDocumentor tag marker."

 - For `*/`: " If you need to use the closing comment "\*/" in a DocBlock, use the special escape sequence "{@*}."

Closes #11208

COPYBARA_INTEGRATE_REVIEW=#11208 from bshaffer:more-readable-phpdoc-escaping a75f974
PiperOrigin-RevId: 603091642
deannagarcia pushed a commit to deannagarcia/protobuf that referenced this issue Jun 20, 2024
@bshaffer @deannagarcia
feat: more readable phpdoc escaping (protocolbuffers#11208)
d9e4050 
The PHPDoc escaping in PHP is aggressive in that it escapes some character sequences that don't need to be escaped (`/*`), and it uses HTML entities to escape others (`*/` and `@`) instead of the recommended PHPDoc escape sequences.

For Example, in [`Google\Api\RoutingParameter`](https://github.com/googleapis/common-protos-php/blob/main/src/Api/RoutingParameter.php#L42):

```
 * path_template: "projects/&protocolbuffers#42;&protocolbuffers#47;{table_location=instances/&protocolbuffers#42;}/tables/&protocolbuffers#42;"
```

Should be escaped as:

```
 * path_template: "projects/{@*}{table_location=instances/*}/tables/*"
```

according to [the PHPDoc guide](https://manual.phpdoc.org/HTMLframesConverter/default/phpDocumentor/tutorial_phpDocumentor.howto.pkg.html#basics.desc):

 - For `@`: "if you need an actual "@" in your DocBlock's description parts, you should be careful to either ensure it is not the first character on a line, or else escape it ("\\@") to avoid it being interpreted as a PhpDocumentor tag marker."

 - For `*/`: " If you need to use the closing comment "\*/" in a DocBlock, use the special escape sequence "{@*}."

Closes protocolbuffers#11208

COPYBARA_INTEGRATE_REVIEW=protocolbuffers#11208 from bshaffer:more-readable-phpdoc-escaping a75f974
PiperOrigin-RevId: 603091642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@protobufel @xfxyjwf