Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python module does not compile, because google/protobuf/stubs/map_util.h is missing #6186

Closed
moubctez opened this issue May 29, 2019 · 0 comments
Closed

Python module does not compile, because google/protobuf/stubs/map_util.h is missing #6186

moubctez opened this issue May 29, 2019 · 0 comments
Assignees
@acozzette
Labels
bug

Comments

@moubctez
Copy link

What version of protobuf and what language are you using?
Version: v3.8.0
Language: C++/Python

What operating system (Linux, Windows, ...) and version?
Any

What runtime / compiler are you using (e.g., python version or gcc version)
Clang 8.0.0/Python 3.7.3

What did you do?
Steps to reproduce the behaviour:

  1. Build and install protobuf-cpp 3.8.0
  2. Build and install protobuf-python 3.8.0 (I used the source distribution from PyPI)

What did you expect to see
Building Python module succeeds.

What did you see instead?
Building fails with google/protobuf/pyext/map_container.cc:46:10: fatal error: 'google/protobuf/stubs/map_util.h' file not found

Proposed fix
Apply this patch

--- src/Makefile.am.orig	2019-05-29 10:28:11.000000000 +0000
+++ src/Makefile.am
@@ -72,6 +72,7 @@ nobase_include_HEADERS =                
   google/protobuf/stubs/hash.h                                   \
   google/protobuf/stubs/logging.h                                \
   google/protobuf/stubs/macros.h                                 \
+  google/protobuf/stubs/map_util.h                               \
   google/protobuf/stubs/mutex.h                                  \
   google/protobuf/stubs/once.h                                   \
   google/protobuf/stubs/platform_macros.h                        \
@moubctez moubctez changed the title 3.8.0 Python module does not compile, because google/protobuf/stubs/map_util.h is missing Python module does not compile, because google/protobuf/stubs/map_util.h is missing May 29, 2019
@acozzette acozzette mentioned this issue Jun 6, 2019
Merged
acozzette added a commit to acozzette/protobuf that referenced this issue Jun 19, 2019
@acozzette
Added stubs/map_util.h to list of installed headers
9f3a2e7 
This should fix issue protocolbuffers#6186. I also had to remove a couple unnecessary
const keywords in map_util.h because the no_warning_test was showing
errors about those.
acozzette added a commit that referenced this issue Jun 21, 2019
@acozzette
Added stubs/map_util.h to list of installed headers
4aa7750 
This should fix issue #6186. I also had to remove a couple unnecessary
const keywords in map_util.h because the no_warning_test was showing
errors about those.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acozzette acozzette

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@acozzette @BSBandme @moubctez