Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python cpp implementation doesn't build with python 2.6 #758

Closed
xfxyjwf opened this issue Aug 27, 2015 · 4 comments
Closed

Python cpp implementation doesn't build with python 2.6 #758

xfxyjwf opened this issue Aug 27, 2015 · 4 comments

Comments

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Aug 27, 2015

Failing travis test: https://travis-ci.org/google/protobuf/jobs/77443313

Error message:

google/protobuf/pyext/message.cc:1783:14: error: ‘PyFloat_STR_PRECISION’ was not declared in this scope

This symbol is introduced in a down-integration commit (i.e., first added in our internal code base).

@haberman
Copy link
Member

Looking into this.

I'm not sure this needs to hold up the release. Python 2.6 is extremely old and we only decided to support it because RedHat might still be distributing it. If only pure-Python worked for this beta release on Python 2.6, I think that would be acceptable.

@haberman
Copy link
Member

I think I can fix this bug relatively easily. Do you want to send a PR?

@xfxyjwf
Copy link
Contributor Author

xfxyjwf commented Aug 27, 2015

We are releasing beta-1 without this. Let's fix it before merging beta-1 to master though.

haberman added a commit to haberman/protobuf that referenced this issue Aug 28, 2015
Change-Id: I590b34b96c84a3ba6e094a0bd86f153147ade3d3
haberman added a commit that referenced this issue Aug 29, 2015
@QuLogic
Copy link

QuLogic commented Sep 17, 2015

Just as a side note.

@xfxyjwf xfxyjwf closed this as completed Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants