Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Add ability to remove single element from repeated value list #968

Closed
philsttr opened this issue Nov 12, 2015 · 0 comments
Closed

Java: Add ability to remove single element from repeated value list #968

philsttr opened this issue Nov 12, 2015 · 0 comments
Assignees
@xfxyjwf
Labels
enhancement java wontfix

Comments

@philsttr
Copy link
Contributor

For the generated Message.Builders in java, the following methods are available for manipulating repeated values:

  • addX(xtype x)
  • setX(int index, xtype x)
  • clearX()

I would like to see the following method added:

  • removeX(int index)

Currently, it appears the only way to remove an element from the list is to copy the list to a new list, call clearX(), and then call addX(x) for all but the excluded elements. This is an expensive procedure.
@xfxyjwf xfxyjwf closed this as completed Mar 21, 2018
adellahlou pushed a commit to adellahlou/protobuf that referenced this issue Apr 20, 2023
@gideongoodwin @dcodeIO
New: Add IParseOptions#alternateCommentMode (protocolbuffers#968)
8400f87 
This PR adds a new option to IParseOptions, alternateCommentMode. When enabled, this activates an alternate comment parsing mode that preserves double-slash comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xfxyjwf xfxyjwf

Labels
enhancement java wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philsttr @xfxyjwf