Implement IComparable<Duration> for the Duration type (C#) #10441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that unlike Timestamp, this does *not* also overload comparison operators. Adding a `==` overload now would be a breaking change (as it would change the meaning of existing code from a reference comparison to a value comparison), and implementing `<`, `<=`, `>=` and `>` without implementing `==` would be odd. Implementing `IComparable<T>` makes sorting much easier, however. Fixes protocolbuffers#7628
amanda-tarafa
approved these changes
Aug 26, 2022
| /// </remarks> | ||
| /// <param name="other">The duration to compare with this object.</param> | ||
| /// <returns>An integer indicating whether this duration is shorter or longer than <paramref name="other"/>.</returns> | ||
| public int CompareTo(Duration other) |
There was a problem hiding this comment.
Unknown fields are not being taken into account here but they are being taken into account for equality and hashcode. Not sure how to take them into account but it may happen that something equals here is then not equals with Equals.
Maybe a note in the docs is enough.
There was a problem hiding this comment.
Given that this is a well-known type, we really shouldn't be getting any unknown fields - I think it's fine for the comparison to ignore them.
|
@fowles: If you could merge this, that would be great :) |
fowles
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that unlike Timestamp, this does not also overload comparison
operators. Adding a
==overload now would be a breaking change (asit would change the meaning of existing code from a reference
comparison to a value comparison), and implementing
<,<=,>=and
>without implementing==would be odd.Implementing
IComparable<T>makes sorting much easier, however.Fixes #7628