Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protoc: fix consistency with parsing very large decimal numbers #10555

Merged
merged 11 commits into from
Sep 15, 2022
Merged

protoc: fix consistency with parsing very large decimal numbers #10555

merged 11 commits into from
Sep 15, 2022

Commits on Sep 15, 2022

  1. allow excessively large int literal values (that would otherwise over… 

    …flow uint64 or underflow int64) to be used as float/double values
    @jhump
    jhump committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    2270d3f View commit details
    Browse the repository at this point in the history

  2. add allowed ranges to error messages

    @jhump
    jhump committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    87f24e4 View commit details
    Browse the repository at this point in the history

  3. change format of int range in error message; use macro to make DRY

    @jhump
    jhump committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    4e54ec2 View commit details
    Browse the repository at this point in the history

  4. add test to verify parsing of extremely large decimal integers to dou… 

    …ble values
    @jhump
    jhump committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    35dd193 View commit details
    Browse the repository at this point in the history

  5. use template instead of macro

    @jhump
    jhump committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    4c69337 View commit details
    Browse the repository at this point in the history

  6. address latest review comments

    @jhump
    jhump committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    7702355 View commit details
    Browse the repository at this point in the history

  7. put helpers into anon namespace

    @jhump
    jhump committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    0bc90b1 View commit details
    Browse the repository at this point in the history

  8. avoid possible exception; error if octal or hex literal that is too l… 

    …arge
    @jhump
    jhump committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    f82be68 View commit details
    Browse the repository at this point in the history

  9. use normal conditional

    @jhump
    jhump committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    d6acffb View commit details
    Browse the repository at this point in the history

  10. initialize var to avoid undefined return val

    @jhump
    jhump committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    0362a12 View commit details
    Browse the repository at this point in the history

  11. oops, fix name: LOG -> GOOGLE_LOG

    @jhump
    jhump committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    7e745c4 View commit details
    Browse the repository at this point in the history