Migrate utf8_range dependency to a git subtree #11608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-subtree-dir: third_party/utf8_range git-subtree-split: 72c943dea2b9240cd09efde15191e144bc7c7d38
mkruskal-google
requested review from
zhangskz
and removed request for
a team
zhangskz
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
I think this should land internally first or maybe copybara needs to be fixed after-the-fact since utf8_range.cmake isn't github only. Also just sanity checking that this doesn't affect how we use the utf8_range submodule for php release (https://github.com/protocolbuffers/protobuf/blob/main/php/BUILD.bazel#L34)? (pretty sure we have test coverage for this though)
|
This shouldn't affect bazel builds at all, since we depend on utf8_range through Bazel. I plan on importing this with copybara, it should work? I might have to force it in tho :P |
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 20, 2023
This will make the CMake workflow easier, where users won't need to either install utf8_range or initialize our submodules. Since this is a relatively small library that's owned by us, we can just bundle it with protobuf as a subtree Closes #11608 COPYBARA_INTEGRATE_REVIEW=#11608 from mkruskal-google:utf8_range_dep 57d5d91 FUTURE_COPYBARA_INTEGRATE_REVIEW=#11608 from mkruskal-google:utf8_range_dep 57d5d91 PiperOrigin-RevId: 503304867
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make the CMake workflow easier, where users won't need to either install utf8_range or initialize our submodules. Since this is a relatively small library that's owned by us, we can just bundle it with protobuf as a subtree