Added support for binary gems. #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,6 +21,11 @@ else | |||
| ext.ext_dir = "ext/google/protobuf_c" | |||
| ext.lib_dir = "lib/google" | |||
| end | |||
|
|
|||
| task 'gem:windows' do | |||
| require 'rake_compiler_dock' | |||
There was a problem hiding this comment.
I think you need to add
s.add_development_dependency "rake-compiler-dock"
in the Gemfile for it to work.
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
@nicolasnoble would you mind confirming that you want to contribute those two changes to this repo, to make the CLA bot happy? |
|
I am a googler and hence am okay with these commits being contributed to Google ;-) |
|
Thanks. :) |
haberman
added a commit
that referenced
this pull request
Feb 8, 2016
Added support for binary gems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.