Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back the namespace_packages arg in setup.py. #1298

Merged
merged 1 commit into from Mar 5, 2016

Commits on Mar 5, 2016

  1. Add back the namespace_packages arg in setup.py.

    Improves protocolbuffers#1296.
    
    The problem: in the previous patch, we tweaked the __init__.py files to use
    namespaces, but no longer declared ourselves as a namespace package. The
    second half was unwise.
    
    Note that this only comes up when installing protobuf alongside another
    package that also installs into the google namespace; as of right now, the
    only PyPI package that does is googleapis-common-protos, though the GAE SDK
    also uses google.appengine. Installing either or both of those alongside this
    package now works.
    
    The case that still remains is the upgrade path, which is also what worried me
    in protocolbuffers#713. It seems that if protobuf 2.6.1 is installed, there's no way to
    safely upgrade that to work with a newer protobuf. However, `pip uninstall` &&
    `pip install` does the trick.
    craigcitro committed Mar 5, 2016
    Configuration menu
    Copy the full SHA
    0e7c0c2 View commit details
    Browse the repository at this point in the history