Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JRuby 9.3 and 9.4 to the test matrix under both Bazel versions. #13296

Closed
wants to merge 4 commits into from
Closed

Add JRuby 9.3 and 9.4 to the test matrix under both Bazel versions. #13296

wants to merge 4 commits into from

Conversation

JasonLunn
Copy link
Contributor

Prepare for 9.2 to be removed.

@JasonLunn JasonLunn requested a review from a team as a code owner July 12, 2023 22:16
@JasonLunn JasonLunn requested review from perezd and removed request for a team July 12, 2023 22:16
@JasonLunn JasonLunn added ruby jruby Issues unique to the JRuby interpreter 🅰️ safe for tests Mark a commit as safe to run presubmits over labels Jul 12, 2023
mkruskal-google
mkruskal-google reviewed Jul 12, 2023
View reviewed changes
.github/workflows/test_ruby.yml Outdated Show resolved Hide resolved
.github/workflows/test_ruby.yml Show resolved Hide resolved
.github/workflows/test_ruby.yml Outdated Show resolved Hide resolved
.github/workflows/test_ruby.yml Outdated Show resolved Hide resolved
@mkruskal-google mkruskal-google added 🅰️ safe for tests Mark a commit as safe to run presubmits over and removed 🅰️ safe for tests Mark a commit as safe to run presubmits over labels Jul 12, 2023
@JasonLunn
Fixes and test fixes for JRuby 9.4.x.
c371adc 
Fixes handling of beginless and endless ranges.
Add `resolve_feature_path` to the list of methods defined on `Array` that `RepeatedField` is expected to expose.
Workaround jruby/jruby#7851 by explicit bounds checking when initializing RepeatedField.
@JasonLunn JasonLunn requested a review from a team as a code owner July 13, 2023 18:32
@JasonLunn JasonLunn requested review from esorot and removed request for a team July 13, 2023 18:32
@fowles fowles added 🅰️ safe for tests Mark a commit as safe to run presubmits over and removed 🅰️ safe for tests Mark a commit as safe to run presubmits over labels Jul 14, 2023
@zhangskz zhangskz added 🅰️ safe for tests Mark a commit as safe to run presubmits over and removed 🅰️ safe for tests Mark a commit as safe to run presubmits over labels Jul 14, 2023
zhangskz pushed a commit that referenced this pull request Jul 17, 2023
@JasonLunn @zhangskz
Add JRuby 9.3 and 9.4 to the test matrix under both Bazel versions. (#…
2402814 
…13296)

Prepare for 9.2 to be removed.

Closes #13296

COPYBARA_INTEGRATE_REVIEW=#13296 from protocolbuffers:jruby_version_bump 82924ab
PiperOrigin-RevId: 548279470
@JasonLunn JasonLunn deleted the jruby_version_bump branch August 1, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkruskal-google mkruskal-google mkruskal-google left review comments

@haberman haberman haberman approved these changes

@fowles fowles fowles approved these changes

@zhangskz zhangskz zhangskz approved these changes

Assignees
No one assigned
Labels
🅰️ safe for tests Mark a commit as safe to run presubmits over jruby Issues unique to the JRuby interpreter ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JasonLunn @haberman @fowles @mkruskal-google @zhangskz