protoc: validate that reserved range start is before end #13474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation for existing similar check for enum reserved ranges
fowles
approved these changes
Aug 8, 2023
fowles
added
protoc
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
|
this is going to take a few days, I need to cleanup google3. |
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 12, 2023
This addresses #13442. This also backfills the tests to add tests for the two checks that were already implemented as well as one for the newly added check. Finally, this fixes the location information so that positions for reserved ranges are correctly reported. (The previous check that already existed, for enums, failed to show line and column info.) Closes #13474 COPYBARA_INTEGRATE_REVIEW=#13474 from jhump:jh/validate-msg-reserved-range-order 661adc7 FUTURE_COPYBARA_INTEGRATE_REVIEW=#13474 from jhump:jh/validate-msg-reserved-range-order 661adc7 PiperOrigin-RevId: 556348808
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
This addresses #13442. This also backfills the tests to add tests for the two checks that were already implemented as well as one for the newly added check. Finally, this fixes the location information so that positions for reserved ranges are correctly reported. (The previous check that already existed, for enums, failed to show line and column info.) Closes #13474 COPYBARA_INTEGRATE_REVIEW=#13474 from jhump:jh/validate-msg-reserved-range-order 661adc7 FUTURE_COPYBARA_INTEGRATE_REVIEW=#13474 from jhump:jh/validate-msg-reserved-range-order 661adc7 PiperOrigin-RevId: 556348808
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #13442. This also backfills the tests to add tests for the two checks that were already implemented as well as one for the newly added check.
Finally, this fixes the location information so that positions for reserved ranges are correctly reported. (The previous check that already existed, for enums, failed to show line and column info.)