Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #14409

Closed
wants to merge 1 commit into from
Closed

Fix typos #14409

wants to merge 1 commit into from

Conversation

xiaolou86
Copy link
Contributor

No description provided.

@xiaolou86 xiaolou86 requested review from a team as code owners October 16, 2023 03:59
@xiaolou86 xiaolou86 requested review from fowles and removed request for a team October 16, 2023 03:59
@google-cla
Copy link

google-cla bot commented Oct 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@fowles
Copy link
Member

fowles commented Oct 16, 2023

thanks for the fixes! We do require a CLA for all contributions however.

@xiaolou86 xiaolou86 closed this Oct 17, 2023
@xiaolou86
Copy link
Contributor Author

@fowles Thanks for your review. I have signed the CLA.

@xiaolou86 xiaolou86 reopened this Oct 17, 2023
@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 17, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 17, 2023
@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 17, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 17, 2023
@fowles fowles added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 17, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 17, 2023
@xiaolou86
Copy link
Contributor Author

@fowles why did the bot close the PR? could you help to reopen it?

@fowles
Copy link
Member

fowles commented Oct 18, 2023

because there was an internal thing that needed updating for the spellings, I had to submit this as a separate change (48ebb9b) so the bot closed it when it merged that in. You are still listed as the primary author of that change though

@xiaolou86
Copy link
Contributor Author

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fowles fowles fowles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xiaolou86 @fowles @mkruskal-google