Breaking change: remove support for PHP generic services #15164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_592660785
branch
from
4852e43
to
ab269b7
Compare
copybara-service
bot
changed the title
php_generic_services option
copybara-service
bot
force-pushed
the
test_592660785
branch
2 times, most recently
from
9778e0f
to
1f61cb2
Compare
Generic services have been deprecated for about 14 years. This is technically a breaking change, but fortunately the `php_generic_services` option appears to have little or no usage. I could not find any examples of open source code using it. PiperOrigin-RevId: 592677762
copybara-service
bot
force-pushed
the
test_592660785
branch
from
1f61cb2
to
40ad3fa
Compare
copybara-service
bot
closed this pull request by merging all changes
into
main
in
40ad3fa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change: remove support for PHP generic services
Generic services have been deprecated for about 14 years. This is technically a
breaking change, but fortunately the
php_generic_servicesoption appears tohave little or no usage. I could not find any examples of open source code
using it.