Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed syntax and added has_presence/is_packed. #15313

Closed
wants to merge 1 commit into from
Closed

Conversation

haberman
Copy link
Member

@haberman haberman commented Jan 5, 2024

No description provided.

@haberman haberman requested a review from a team as a code owner January 5, 2024 23:34
@haberman haberman requested review from ericsalo and removed request for a team January 5, 2024 23:34
copybara-service bot pushed a commit that referenced this pull request Jan 5, 2024
Closes #15313

COPYBARA_INTEGRATE_REVIEW=#15313 from protocolbuffers:ruby-rm-syntax 8863c83
FUTURE_COPYBARA_INTEGRATE_REVIEW=#15313 from protocolbuffers:ruby-rm-syntax 8863c83
PiperOrigin-RevId: 596098711
@@ -489,7 +489,7 @@ static VALUE FileDescriptor_alloc(VALUE klass) {
* call-seq:
* FileDescriptor.new => file
*
* Returns a new file descriptor. The syntax must be set before it's passed
* Returns a new file descriptor. May
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May to a builder.?

copybara-service bot pushed a commit that referenced this pull request Jan 8, 2024
copybara-service bot pushed a commit that referenced this pull request Jan 9, 2024
copybara-service bot pushed a commit that referenced this pull request Jan 9, 2024
copybara-service bot pushed a commit that referenced this pull request Jan 9, 2024
@copybara-service copybara-service bot closed this in dbd4dce Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants