[C#] Conformance test: don't skip JsonIgnoreUnknownParsingTest in runner #15369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antongrbin
requested review from
haberman and
jskeet
and removed request for
a team
jskeet
reviewed
Jan 10, 2024
| @@ -72,24 +72,21 @@ private static ConformanceResponse PerformRequest(ConformanceRequest request, Ty | |||
| switch (request.PayloadCase) | |||
| { | |||
| case ConformanceRequest.PayloadOneofCase.JsonPayload: | |||
| JsonParser parser; | |||
There was a problem hiding this comment.
This can be unconditional:
bool ignoreUnknownFields = request.TestCategory == global::Conformance.TestCategory.JsonIgnoreUnknownParsingTest;
JsonParser parser = new JsonParser(new JsonParser.Settings(20, typeRegistry).WithIgnoreUnknownFields(ignoreUnknownFields));There was a problem hiding this comment.
Applied -- thank you!
jskeet
approved these changes
Jan 10, 2024
|
How do we move forward with this? Is there an action item on me? |
haberman
approved these changes
Jan 24, 2024
github-actions
bot
removed
the
🅰️ safe for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#7392 (comment)
This is for completeness - I am not blocked by this change in any way, so feel free to close the PR or treat is a low priority.
Changes
Implement JsonIgnoreUnknownParsingTest in C# conformance test runner.
Tested
Locally with: