C#: Ignore invalid enum string values in JSON, when invalid fields are being ignored. #15758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_604923051
branch
from
69c8a61
to
e4e95f7
Compare
…e being ignored. PiperOrigin-RevId: 605310357
copybara-service
bot
force-pushed
the
test_604923051
branch
from
e4e95f7
to
55e50ba
Compare
copybara-service
bot
closed this pull request by merging all changes
into
main
in
55e50ba
This was referenced Feb 8, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
…wn_fields is set (#15887) # Motivation This PR fixes failing conformance tests for python with name `IgnoreUnknownEnumStringValue`. The JSON parsing spec was discussed in #7392. Recent equivalent changes for other languages: * Swift: apple/swift-protobuf#1345 * C#: #15758 # Changes - 1st commit is a noop refactoring to make relevant _ConvertScalarFieldValue invocations localized - 2nd commit introduces the child exception of `ParseError` named `EnumStringValueParseError` which is suppressed if `ignore_unknown_fields` is set - 3rd commit updates the conformance test failure lists Closes #15887 COPYBARA_INTEGRATE_REVIEW=#15887 from noom:anton/7392/fix-python-test fbcc93a PiperOrigin-RevId: 619288323
elvisdukaj
pushed a commit
to elvisdukaj/protobuf
that referenced
this pull request
Apr 3, 2024
…wn_fields is set (protocolbuffers#15887) # Motivation This PR fixes failing conformance tests for python with name `IgnoreUnknownEnumStringValue`. The JSON parsing spec was discussed in protocolbuffers#7392. Recent equivalent changes for other languages: * Swift: apple/swift-protobuf#1345 * C#: protocolbuffers#15758 # Changes - 1st commit is a noop refactoring to make relevant _ConvertScalarFieldValue invocations localized - 2nd commit introduces the child exception of `ParseError` named `EnumStringValueParseError` which is suppressed if `ignore_unknown_fields` is set - 3rd commit updates the conformance test failure lists Closes protocolbuffers#15887 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#15887 from noom:anton/7392/fix-python-test fbcc93a PiperOrigin-RevId: 619288323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C#: Ignore invalid enum string values in JSON, when invalid fields are being ignored.