[csharp] Fix indentation for MapField with nested Messages #15836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskeet
approved these changes
Feb 14, 2024
|
Thanks, this looks good to me. @mkruskal-google please could you approve after the tests have completed, to kick off the import process? |
github-actions
bot
removed
the
🅰️ safe for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WriteDictionary does not pass indentationLevel downwards to WriteValue. The existing test for
MapFieldonly testsMapField<string, string>, which isn't affected by the issue.Tests are added for this issue.
Note: I also added
WriteValueWithIndentation_MapWithEmptyNestedto ensure this change would break things, but I doubt if it's necessary. Let me know whether to remove it.