feat: add visionOS deployment target for Cocoapods #15917
Conversation
thomasvl
added
c++
objective-c
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
| @@ -45,6 +45,7 @@ Pod::Spec.new do |s| | |||
| s.osx.deployment_target = '10.12' | |||
| s.tvos.deployment_target = '12.0' | |||
| s.watchos.deployment_target = '6.0' | |||
| s.visionos.deployment_target = '1.0' | |||
There was a problem hiding this comment.
When was visionOS support added to CocoaPods? i.e. - do we need to raise the s.cocoapods_version = '>= 1.12.0' line or will versions that old be ok with this directive?
ps - can you add back the blank line that was here to keep the deployment_target info grouped?
There was a problem hiding this comment.
added blank line, and I saw Kingfisher and SDWebImage have not limit cocoapods_version. Maybe it is not nessary, I will take a check about it if I have free time.
There was a problem hiding this comment.
@paulb777 do you happen to know if one should to raise the cocoapods_version when adding a visionos.deployment_target value?
|
CocoaPods Support was introduced in 1.13.0 and there were fixes in 1.15.0 - so at least 1.13.0 and maybe 1.15.0. https://github.com/CocoaPods/CocoaPods/blob/master/CHANGELOG.md and there are still outstanding issues that may or may not be solved: https://github.com/CocoaPods/CocoaPods/issues?q=is%3Aissue+is%3Aopen+visionos Firebase requires Swift PM for visionOS support. |
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
add visionOS deployment target for Cocoapods