Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the use of c++ keywords within namespace names #15954

Closed
wants to merge 2 commits into from

Conversation

Ilukatsk
Copy link
Contributor

No description provided.

@Ilukatsk Ilukatsk requested a review from a team as a code owner February 26, 2024 09:19
@Ilukatsk Ilukatsk requested review from sbenzaquen and removed request for a team February 26, 2024 09:19
Copy link

google-cla bot commented Feb 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@fowles fowles added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 26, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 26, 2024
@Ilukatsk
Copy link
Contributor Author

Do I need to do something to fix the issue with failed PHP test before sbenzaquen will approve the merge or should I just wait?

@zhangskz
Copy link
Member

Thanks for the ping! We temporarily disabled the failing PHP test which was blocking the PR from going through. Rebasing would unstick this, but we've already imported your PR to be merged. No action is needed on your part at this time -- but please give us another ping if you don't see this go through in the next day or so.

@Ilukatsk
Copy link
Contributor Author

Good afternoon. Sorry for bothering, but is it known, when the commit will be included in the release version?

@zhangskz
Copy link
Member

This should be picked up in our next quarterly 27.x minor release, which we should start cutting RC's for ~next week!

@Ilukatsk
Copy link
Contributor Author

Great! Thanks for the info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants