Add null to the list of reserved words.
#16784
Merged
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_631786175
branch
from
cb6eaf8
to
39aeaf2
Compare
The previous change claimed to do this in addition to `true` and `false`, but it was not actually in the code. To reiterate the text from the earlier change, now actually reflected entirely in the code: > The identifiers `true`, `false`, and `null` are effectively reserved words in Java, although for some reason they are listed separately from the "keywords" in the Java Language Specification. > > This doesn't matter for regular fields, because a proto field called `true` will be accessed with `getTrue` and `setTrue`. But for extensions, the generated Java code will have a public static field whose name is the same as the name of the extension field, with `_` appended if the name is a reserved word. Previously there was no `_` for `true` etc, so the generated code would not compile. This change should not affect any existing client code in Java. If someone had tried to use an extension called `true` (etc), they would have found that the generated proto code did not compile. Now it is possible to reference such an extension as `true_`. PiperOrigin-RevId: 632174190
copybara-service
bot
force-pushed
the
test_631786175
branch
from
39aeaf2
to
510c143
Compare
copybara-service
bot
closed this pull request by merging all changes
into
main
in
510c143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
nullto the list of reserved words.The previous change claimed to do this in addition to
trueandfalse, but it was not actually in the code.To reiterate the text from the earlier change, now actually reflected entirely in the code:
This change should not affect any existing client code in Java. If someone had tried to use an extension called
true(etc), they would have found that the generated proto code did not compile. Now it is possible to reference such an extension astrue_.