Use bool HasHasbits(const FieldDescriptor*) instead of manual checks. #16842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_633400555
branch
from
cd2880f
to
bd2acff
Compare
It is not sufficient to check schema_.HasHasbits() followed by naively skipping repeated and oneof fields as that can miss proto3 messages with message fields and other scalar fields without "optional" keyword. Use internal::cpp::HasHasbits(const FieldDescriptor*) instead. PiperOrigin-RevId: 633633184
copybara-service
bot
force-pushed
the
test_633400555
branch
from
bd2acff
to
448e326
Compare
copybara-service
bot
closed this pull request by merging all changes
into
main
in
448e326
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use bool HasHasbits(const FieldDescriptor*) instead of manual checks.
It is not sufficient to check schema_.HasHasbits() followed by naively skipping
repeated and oneof fields as that can miss proto3 messages with message fields
and other scalar fields without "optional" keyword.
Use internal::cpp::HasHasbits(const FieldDescriptor*) instead.